Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove secret in code (!!) #1

Closed
angelofallars opened this issue Oct 28, 2021 · 1 comment
Closed

Remove secret in code (!!) #1

angelofallars opened this issue Oct 28, 2021 · 1 comment

Comments

@angelofallars
Copy link

In line 5 of app.py, there is a secret exposed in public code:

 1  from pypresence import Presence
 2  import time
 3  from itertools import cycle
 4  
 5  client_id = <secret code!>
 6  
 7  start_time = time.time()
 8  
 9  RPC = Presence(client_id=client_id)
10  RPC.connect()

I strongly suggest using python-dotenv if you don't want others to see your Discord client ID and do whatever they want with it.

@edmer664
Copy link
Owner

As far as I know, client_id is safe to expose as this is used to identify the app you're going to display in the rich presence.

similarly to vimsence :
image
the client_id is also exposed

BTW, thanks for the concern

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants