Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scheduler doesn't work #8

Open
ipwnponies opened this issue Mar 20, 2019 · 3 comments
Open

Scheduler doesn't work #8

ipwnponies opened this issue Mar 20, 2019 · 3 comments

Comments

@ipwnponies
Copy link
Collaborator

The scheduler was disabled during project boilerplate changes.

mealpy/mealpy.py

Lines 147 to 151 in 9e60e06

# scheduler.start()
if __name__ == '__main__':
execute_reserve_meal()

We'll want some way to allow user to run this adhoc or as scheduled task.

@edmundmok edmundmok added the bug label Mar 21, 2019
@ipwnponies ipwnponies added blocked Currently blocked, see ticket for more context good first issue labels Mar 28, 2019
@ipwnponies
Copy link
Collaborator Author

I briefly tested this and it works with the apscheduler v3.6.0 (should be pinned, #13). This is now blcoked on #4, as we need the CLI swtiches to choose "scheduled" vs. "adhoc" runs.

@ipwnponies ipwnponies removed the blocked Currently blocked, see ticket for more context label Apr 27, 2019
@ipwnponies
Copy link
Collaborator Author

@edmundmok do you think this is a good feature to have? Personally, I would prefer to set up cronjob/windows task instead. This script doesn't run anything concurrently, so apscheduler is essentially an in-process cron scheduler, no additional benefit that I can forsee.

@edmundmok
Copy link
Owner

I think it would still be good to have a scheduler that works out of the box, so not much configuration is required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants