Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calling compilemessages management command from setup.py breaks tox. #74

Closed
mrmachine opened this issue May 25, 2015 · 2 comments
Closed
Labels

Comments

@mrmachine
Copy link
Contributor

When trying to run tox on a project that is installing django-fluent-pages from git in requirements.txt (with -e), Django raises an exception when compilemessages is called because at that point, the project (and its settings module), of which django-fluent-pages is a dependency, has not yet been installed into the virtualenv.

This doesn't happen when installing normally (not via tox), perhaps because the current working directory is added to the PYTHONPATH?

Can that call be made optional somehow, or otherwise not raise an exception when it fails for this reason?

Alternatively, I'll have to install django-fluent-pages without -e which makes it more difficult to contribute any changes back.

@vdboor
Copy link
Contributor

vdboor commented Jun 19, 2015

Ahh this is a good point. I didn't run into this yet because:

  • I also have Django in the global path
  • I typically use add2virtualenv to add paths, only recently found out that pip instal -e /local/path provides a similar and better way.

This is definitely a bug, and I'm all for catching the errors in a setup.py develop mode. As long as sdist will be unaffected, I'm happy! :)

@vdboor vdboor added the bug label Jun 19, 2015
@vdboor
Copy link
Contributor

vdboor commented Jun 19, 2015

Fixed in 215cdb6

@vdboor vdboor closed this as completed Jun 19, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants