Force list for lang_dict['fallbacks'] #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vdboor
added a commit
that referenced
this pull request
Feb 24, 2016
Force list for lang_dict['fallbacks']
|
Thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This appears to be a regression from v1.5.x to v1.6.0
What is not clear is if this is the correct fix, but it should be benign regardless.
I think the real issue is that now fallbacks should be a list. The problem is if you don't explicitly set fallbacks in the settings dict, then Parler will do
fallbacks=settings.LANGUAGE_CODE, but as a string, not as a list. Perhaps further fixes will be required so that Parler will setfallbacks=[settings.LANGAUGE_CODE]instead.For those searching, the error one might get is:
TypeError: can only concatenate list (not "unicode") to list. The work-around until this PR is merged and released is to explicitly set your fallbacks to something (even an empty list[]is fine), just don't let Parler do it for you.