Save translation object even with default translation data #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vdboor
added a commit
that referenced
this pull request
Aug 4, 2015
There is no need to check for is_empty, as it the pk check handles it. For completeness check for `pk is None` which is what all other code does. As strange as it seems, a PK of 0 is allowed in databases.
|
I've merged your commit into a separate branch! It seems to be pretty ok, but I'll have to test whether it won't influence my projects - especially when working with multiple translated models. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update of save_translation method. Now it saves object even if translation is empty (with default values). This fixes #80