Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test polymorphic #89

Closed
wants to merge 9 commits into from
Closed

Conversation

jrief
Copy link
Contributor

@jrief jrief commented May 30, 2015

This is just to prove that #51 really causes a problem.
I just added the example code from the docs, but the result is the same. If I run the unit test, I get:

File "../lib/python2.7/site-packages/django/db/models/fields/related.py", line 1259, in set_field_name
    self.field_name = self.field_name or self.to._meta.pk.name
AttributeError: 'NoneType' object has no attribute 'name'

Unfortunately I have no idea where to fix that. Can you please give me some hints. I reported this issue in November 2014 and it prevents me from migrating to Django-1.7 and further.

@jrief
Copy link
Contributor Author

jrief commented May 31, 2015

See https://travis-ci.org/edoburu/django-parler/jobs/64733375
Whats interesting, it works well with Python-3.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.06%) to 84.8% when pulling 19db15a on jrief:test-polymorphic into 7d15791 on edoburu:master.

@vdboor
Copy link
Contributor

vdboor commented Oct 1, 2015

Hi! Thanks for providing this - this really helps debugging it.

I've been looking into it briefly, and it seems that switching the inheritance order does have effect. You can see that at 238cc97 In the other ordering, I got an SQL query error.

@vdboor
Copy link
Contributor

vdboor commented Oct 1, 2015

FYI, I merged all your commits, but rebased them first to get rid of the additional upstream merges.

@vdboor
Copy link
Contributor

vdboor commented Oct 5, 2015

Your test can be found in the custom branch: https://github.com/edoburu/django-parler/compare/jrief-test-polymorphic since that needs further testing

@vdboor vdboor closed this in 7d612bb Nov 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants