Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow foreign keys to be strings #3

Merged
merged 2 commits into from
Feb 6, 2018
Merged

Conversation

wesleykendall
Copy link
Contributor

Hello, awesome project! I encountered a bug when 'auth.User' was provided as a foreign key. It's valid to have a string path as a Foreign Key, and this change just prints the string path.

I'm not sure of other places in the code that would need to be updated to handle this case. Maybe we can try to update those too?

@vdboor vdboor merged commit 8ee0048 into sphinx-doc:master Feb 6, 2018
@vdboor
Copy link
Contributor

vdboor commented Feb 6, 2018

Thanks a lot! Glad you like it.

@vdboor
Copy link
Contributor

vdboor commented Feb 6, 2018

I'm not sure of other places in the code that would need to be updated to handle this case. Maybe we can try to update those too?

One change would be to use apps.get_model() to fetch the actual class, and print that instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants