Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the string as cls_path if the related_model is specified as a string #9

Merged
merged 3 commits into from
Apr 30, 2018

Conversation

zd42
Copy link
Contributor

@zd42 zd42 commented Apr 28, 2018

Sorry for the merge request clutter, but I didn't see that the same assumption was made elsewhere too.

@codecov-io
Copy link

codecov-io commented Apr 29, 2018

Codecov Report

Merging #9 into master will decrease coverage by 1.99%.
The diff coverage is 9.09%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master       #9   +/-   ##
=======================================
- Coverage   58.98%   56.98%   -2%     
=======================================
  Files           6        6           
  Lines         178      186    +8     
=======================================
+ Hits          105      106    +1     
- Misses         73       80    +7
Impacted Files Coverage Δ
sphinxcontrib_django/docstrings.py 41.6% <9.09%> (-1.81%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8099c44...3d588ff. Read the comment docs.

@vdboor vdboor merged commit a280fa5 into sphinx-doc:master Apr 30, 2018
@vdboor
Copy link
Contributor

vdboor commented Apr 30, 2018

Thanks for the PR! I'm quite surprised to learn that this issue could still occur.
Could you also write a unit that that shows this situation?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants