Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove config file creation at startup #50

Open
edouardparis opened this issue Dec 5, 2021 · 0 comments
Open

Remove config file creation at startup #50

edouardparis opened this issue Dec 5, 2021 · 0 comments

Comments

@edouardparis
Copy link
Owner

edouardparis commented Dec 5, 2021

After thinking more about it, the .lntop/config.toml creation at start up was a mistake which should be fixed in next versions.
I think everything needs to be more explicit and reflects the lncli behaviour:
https://github.com/lightningnetwork/lnd/blob/master/cmd/lncli/main.go#L263

  • lntop: search for config file in .lntop (for retro compatibility), starts lntop with all default values if no file is found
  • lntop --rpcserver=<...> --tlscertpath=<...> --macaroonpath=<...> starts lntop with specified values
  • lntop --conf <...> starts with the config values

The user then creates an alias the .bashrc according to his needs.
(tldr: lntop should not create a default config file "polluting" user config)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant