Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update actions in channel view #75

Open
hieblmi opened this issue Jul 30, 2022 · 3 comments
Open

Update actions in channel view #75

hieblmi opened this issue Jul 30, 2022 · 3 comments

Comments

@hieblmi
Copy link
Contributor

hieblmi commented Jul 30, 2022

I am thinking of editing capabilities in the channel view. So far lntop is a read-only viewer but it could be very convenient to have actions like 'updating channel params' or 'closing channels' etc.. By clicking 'Enter' on the different fields a input/confirm dialog would pop-up:
image

@hieblmi
Copy link
Contributor Author

hieblmi commented Sep 2, 2022

@rkfg do you think that editing functionality would be in the right place in a *top util or should lntop only have displaying capabilities?

@rkfg
Copy link
Contributor

rkfg commented Sep 2, 2022

On one hand, the original top program is read only. On the other hand, the more popular htop allows to do a lot of changes like process and I/O priority, killing processes etc. So I think historically *top can be more than viewers. However, I'd suggest not allowing any changes by default unless a config option for that is enabled so that lntop is a viewer out of the box but if the user wants so it can also change parameters. Just so that there's no accidental money loss due to closed channel or dropped fees.

@hieblmi
Copy link
Contributor Author

hieblmi commented Sep 2, 2022

Very good suggestion to disable actions by default via config flag. Just wanted to see if functionality like that would get support here before adding it. Just need time to start working on it. Updating fees directly in lntop would save me so much time.

@hieblmi hieblmi changed the title Update actoins in channel view Update actions in channel view Sep 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants