Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple levels of include #7

Closed
barcode opened this issue Apr 27, 2021 · 0 comments · Fixed by #8
Closed

Multiple levels of include #7

barcode opened this issue Apr 27, 2021 · 0 comments · Fixed by #8

Comments

@barcode
Copy link
Contributor

barcode commented Apr 27, 2021

I really like the INCLUDE+ instruction, since it allows to avoid code duplication.
The only problem I encountered was using multiple levels of INCLUDE+ (i.e. including a file using INCLUDE+ as well).

Not sure if i am doing something wrong, there is a limitation or it just is not implemented.
I think it is just not considered in the implementation (i.e. missing recursive call on the included file) but i could be wrong, since i do not know rust.

My files look like this:

Dockerfile.A:

# syntax = edrevo/dockerfile-plus
FROM alpine
RUN echo ">A"
INCLUDE+ Dockerfile.A2
RUN echo "<A"

Dockerfile.A2:

# syntax = edrevo/dockerfile-plus
RUN echo ">A2"
INCLUDE+ Dockerfile.A3
RUN echo "<A2"

Dockerfile.A3:

# syntax = edrevo/dockerfile-plus
RUN echo ">A3"
RUN echo "<A3"

Here you can find the files: https://gitlab.com/barcode/test/-/tree/ci/multi_level_include

The build output is here: https://gitlab.com/barcode/test/-/jobs/1214501093

So is this a problem with my files or is it something else?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant