Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

About OOK pulses & spectrum #14

Closed
JefFan4YC opened this issue Jun 7, 2023 · 3 comments
Closed

About OOK pulses & spectrum #14

JefFan4YC opened this issue Jun 7, 2023 · 3 comments

Comments

@JefFan4YC
Copy link

Hi, @edsonportosilva

I'm testing the basic_OOK codes shown in the ./examples, and the figures seem like:

image

Such results, unlike the preview in basic_OOK_transmission notebook, show a different pulse shaping method leading to abnormal spectrum.

image

With no revision of original codes, I guess it comes from an alternative PulseShape in the up-to-date version. May I know some tips to solve this? Thanks.

@JefFan4YC JefFan4YC changed the title about OOK pulses & spectrum About OOK pulses & spectrum Jun 7, 2023
@JefFan4YC
Copy link
Author

JefFan4YC commented Jun 7, 2023

Ah, I figure out it's the pnorm from optic.dsp leading to this variation. Might be necessary to update it to show the notebook results. However, spectral spikes are still visible in the FFT.

@edsonportosilva
Copy link
Owner

edsonportosilva commented Jun 7, 2023

Hello @JefFan4YC,

This notebook will be changed in an upcoming update of the repository. The issue is that modulateGray(bitsTx, M, 'ook') should be modulateGray(bitsTx, M, 'pam') instead because it is generating the binary electrical signal that will drive the MZM. The MZM expects a binary electrical signal with no DC level, which is not the case in the current notebook, since the symbols are generated already as 'ook'. This is the cause of the problem, not pnorm.

@JefFan4YC
Copy link
Author

JefFan4YC commented Jun 8, 2023

@edsonportosilva Yes, it seems a proper NRZ signal for MZM input is necessary. Again, thanks for your help and looking forward to the new update!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants