Include media 1.4.7 throws error

[danez]

This is the error we get with 1.4.7, it works fine with 1.4.6:

[exec] >> Error: Invalid unit ''.
     [exec] >>         on line 210 of node_modules/include-media/dist/_include-media.scss
     [exec] >> >>     @error $message;
     [exec] >>    ----^
     [exec] Warning:  Use --force to continue.
     [exec] 
     [exec] Aborted due to warnings.
     [exec] WARNING: Invalid unit ''.
     [exec] Backtrace:
     [exec]     node_modules/include-media/dist/_include-media.scss:212, in function `log`
     [exec]     node_modules/include-media/dist/_include-media.scss:486, in function `to-length`
     [exec]     node_modules/include-media/dist/_include-media.scss:457, in function `to-number`
     [exec]     node_modules/include-media/dist/_include-media.scss:350, in function `get-expression-value`
     [exec]     node_modules/include-media/dist/_include-media.scss:391, in function `parse-expression`
     [exec]     node_modules/include-media/dist/_include-media.scss:597, in mixin `media`
     [exec]     node_modules/include-media/dist/_include-media.scss:599, in mixin `media`

with the input:

@include media('screen', '<m')

and the variables being:

$breakpoints: (
  "s": 0px,
  "m": 768px,
  "l": 992px,
  "xl": 1200px,
  "xxl": 99999px
);
$media-expressions: (
  "screen": 'screen',
  "print": 'print',
  "handheld": 'handheld',
  "landscape": '(orientation: landscape)',
  "portrait": '(orientation: portrait)',
  "retina-2-x": '(-webkit-min-device-pixel-ratio: 2), (min-resolution: 192dpi)',
  "retina-3-x": '(-webkit-min-device-pixel-ratio: 3), (min-resolution: 350dpi)'
);

[weaintplastic]

This is due to the following commit: d2188bc from @IanMitchell

Error is in this line: https://github.com/eduardoboucas/include-media/blob/master/src/helpers/_parser.scss#L74

Calling get-expression-value($expression, $operator) with $expression: >=s and $operator: >= trim is returning an empty string.

[KittyGiraudel]

I cannot reproduce on SassMeister. :(

[danez]

but sassmeister seems to have include-media 1.4.2

[KittyGiraudel]

I copied the 1.4.7 dist file.

[weaintplastic]

This is probably due to Libsass. Just try to execute the following in sassmeister and change from sass to Libsass.
For Sass this is working perfectly fine. Libsass is returning an empty string.

@charset 'UTF-8';


///
/// Find first char which is not a space
///
/// @param {String} $string - String to search
/// @param {String} $direction ['left'] - Either 'left' or 'right' to indicate search direction
///
/// @return {Number} - Index of first non-space character
///
@function first-index($string, $direction: 'left') {
  @for $i from 1 through str-length($string) {
    $index: if($direction == 'left', $i, -$i);

    @if str-slice($string, $index, $index) != ' ' {
      @return $index;
    }
  }

  @return 0;
}


@function trim($string) {
  @return str-slice(
    $string,
    first-index($string, 'left'),
    first-index($string, 'right')
  );
}


body {
  background: trim("s");
}

[danez]

sass/libsass#2132

[KittyGiraudel]

God, again… Will this function ever work correctly? :D

[eduardoboucas]

Is there a temporary fix we can release?

[KittyGiraudel]

Maybe there is one of the Libsass repo.

[IanMitchell]

Sorry guys, didn't think to check with libsass 😞

[KittyGiraudel]

We should revert @eduardoboucas.

[eduardoboucas]

Okay, I'll do that.

[eduardoboucas]

Reverted and published 1.4.8.

[IanMitchell]

Working on a libsass fix here: sass/libsass#2133

[danez]

thanks a lot

[weaintplastic]

thank you guys!

[eduardoboucas]

Am I right in thinking that it was fixed here?

[KittyGiraudel]

Yep.