Feature/components #2
Conversation
There was a problem hiding this comment.
Hi 👋 👋 @eduardosancho
Good job so far!
There are some issues that you still need to work on to go to the next project but you are almost there!
To highlight 🎖️
- Nice PR title and Description ✔️
- Awesome design 👍
- Professional README file ✔️
Required Changes ♻️
Check the comments under the review.
Optional suggestions
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
src/components/Calculator.js
Outdated
| export default function Calculator() { | ||
| return ( | ||
| <> |
There was a problem hiding this comment.
- Your
Calculator.jscomponent should be class-based, Please update that
src/App.js
Outdated
| function App() { | ||
| return ( |
There was a problem hiding this comment.
- Your
App.jscomponent should be class-based, Please update that
Approved ✔️Hi @eduardosancho, NICE GIF BTW!!! Congratulations on completing this project! 👏🏼 🎉 You have correctly implemented all of the requirements📃 correctly and without any errors Cheers and good luck in your next milestones! 🍀 Feel free to leave any questions or comments in the PR thread(don't forget to tag me 😄) if something is not 100% clear. As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form. |
What was done in this PR: 🇨🇷