Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/refactor-with-hooks #4

Merged
merged 7 commits into from Feb 11, 2022

Conversation

eduardosancho
Copy link
Owner

@eduardosancho eduardosancho commented Feb 11, 2022

What was done in this PR: ✌️

Refactor the Calculator.js component, from a class-based component to a functional component with hooks


  • Replace the constructor(props) for an object with the same declared variables (total, next, operation). 👷
  • Import {useState} hook to dynamically update the variables mentioned in the last bullet point. ⬆️⬆️⬆️
  • Refactor handleClick function to adapt to the current functional component format. 🕐

sloth

Copy link

@Cathella Cathella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 Status: Approved 🟢

Hi @eduardosancho 👋🏻,

Great good job refactoring from a class-based component to a functional component using hooks 💪🏻!
Your project is complete! There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉

To Highlight 💪🏻

✅ No linter errors.
✅ You used correct Github Flow.
✅ Professional README.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

@eduardosancho eduardosancho merged commit d380d7c into development Feb 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants