Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/router #5

Merged
merged 9 commits into from Feb 15, 2022
Merged

Feature/router #5

merged 9 commits into from Feb 15, 2022

Conversation

eduardosancho
Copy link
Owner

@eduardosancho eduardosancho commented Feb 15, 2022

What was done in this PR: πŸ˜„

  • Separate the math magicians website into 3 pages: Home, Calculator, and Quote. πŸŽ“

  • Follow the design guidelines 🎨

  • Used React basic styling on every page. ⚾

  • All navigation links are displayed on each page. ⚑

  • Use React Router to make 'the routes between sections' work. πŸ”„

kermit

Copy link

@er-contreras er-contreras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @eduardosancho ,

Your project is complete! There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! πŸŽ‰

  • Well done!

Felix

Cheers and Happy coding!πŸ‘πŸ‘πŸ‘

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

@eduardosancho eduardosancho merged commit 278c9dc into development Feb 15, 2022
@eduardosancho eduardosancho deleted the feature/router branch February 15, 2022 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants