Feature/testing #6
Conversation
- Basic Math operations
There was a problem hiding this comment.
Hi @eduardosancho and @JohnFTitor,
Good job so far!
Highlight!
- Good feature branch name ✔️
- No linter errors ✔️
- Descriptive pull request ✔️
- Descriptive commit messages ✔️
- Good code organization and working app ✔️
- All tests are passing ✔️
Hello ✋, you have done well reaching this point of the milestone 🤝 . But there are some issues that you still need to work on to go to the next project but you are almost there!
Status: Required Changes ♻️⛔️
Check the comments under the review.
- [REQUIRED] It would be good to add instructions on how to run the tests in the README by adding the command to run the test so that users can easily find all commands that are needed to run your app.
Optional suggestions
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread and tag me @julie-ify if something is not 100% clear.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
There was a problem hiding this comment.
Hi @eduardosancho 👋,
Your project is complete! There is nothing else to say other than... it's time to merge it 
Congratulations! 🎉
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
What was done in this PR: 💣
Use Jest to test the functionality of the functions and if-statements inside
calculate.jsandoperate.js. 👍Use Jest snapshots to test the
App.jscomponent and Routes in its navbar. 🏃Use React Testing Library (fireEvent) to simulate user interaction. 🤖
All tests pass ✔️