This repository has been archived by the owner on Jun 24, 2024. It is now read-only.
Add Flipper to Classroom #474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This add flipper via redis and the flipper ui. I also created a staff group for previewing features
Since we want to have a lot of flexibility for how we want to flip features we can make a Flippable ActiveSupport::Concern so that any model can have a `flipper_id` be inheriting the concern.
tarebyte
force-pushed
the
flipping-flippers
branch
from
82645ae
to
e0419d1
Compare
7 tasks
|
@johndbritton I've deployed it to prod so you can get a feel for what it looks like. |
|
Looks good to me.
The |
|
@tarebyte Integrating this into the stafftools UI isn't a giant issue, we could treat this like Sidekiq and host it at |
|
@johndbritton that's where I set it up to be 😁 https://github.com/education/classroom/pull/474/files#diff-21497849d8f00507c9c8dcaf6288b136R47 So I think this is good to 🚢 💨 |
|
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we have new features that we are planning to work on, it may be a good idea to have some feature flipping 🐬
Task List
flipper_idBuild Flipper into our own UI?The 🎨
Right now we are just using the default flipper ui, I would like to build this into our own UI.
But I think that is out of the scope of this PR, thoughts?
/cc @johndbritton