Enhance Presenter Proxy #13
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 6, 2022 17:46
Before this change, a "SheetHost" view controller might not be presented if the presenter already presented another view controller. This might have happened when a sheet will be presented due to a state change originating from an app state, rather from a user intent, and when there is already a presented view or a presented alert. This change walks the presented view controller list until it finds a view controller which has no presented view controller and uses this as the presenter. As a result, a sheet now presents on top of any other presented view, even on top of alerts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change, a "SheetHost" view controller might not be presented
if the presenter already presented another view controller. This might
have happened when a sheet will be presented due to a state change
originating from an app state, rather from a user intent, and when there
is already a presented view or a presented alert.
This change walks the presented view controller list until it finds a
view controller which has no presented view controller and uses this as
the presenter. As a result, a sheet now presents on top of any other
presented view, even on top of alerts.