Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webpack #68

Closed
torjusti opened this issue Aug 10, 2018 · 2 comments
Closed

webpack #68

torjusti opened this issue Aug 10, 2018 · 2 comments
Labels
misc/ new feature New feature or request

Comments

@torjusti
Copy link

torjusti commented Aug 10, 2018

If we want #67 without a massive increase to the bundle size, it seems to me that the most reasonable way to go ahead is to make the feature opt-in by a switch in the settings. Then, we can dynamically load the module when enabling the feature in the client.

However, I don't know how the support for code splitting is in Gulp. I think it's a bit easier to do in wbepack using modules such as react-loadable, so this issue is basically for discussing whether we would want to consider moving to webpack or not. I think moving to something like create-react-app would be nice, however there is no support for Stylus in CRA. Writing a custom webpack configuration is certainly viable, though.

Is this something to consider?

@torjusti
Copy link
Author

There is apparently also factor-bundle for browserify

@torjusti torjusti added the misc/ new feature New feature or request label Aug 10, 2018
@torjusti torjusti added this to ToDo in Development via automation Aug 10, 2018
@havfo
Copy link
Collaborator

havfo commented Apr 1, 2019

Fixed in 0449d6f

@havfo havfo closed this as completed Apr 1, 2019
Development automation moved this from ToDo to Done Apr 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
misc/ new feature New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants