Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use named parameters #1

Closed
florian-lefebvre opened this issue Oct 7, 2021 · 2 comments
Closed

Use named parameters #1

florian-lefebvre opened this issue Oct 7, 2021 · 2 comments
Assignees
Labels
question Further information is requested
Projects

Comments

@florian-lefebvre
Copy link
Member

For example at

Email(this._title, this._body, this._sender, this._receivers, this._id, this._messages);
, it would be better to use named parameters like:

Email({required this._title, required this._body, required this._sender, required this._receivers, required this._id, required this._messages}); 

Also, what is the interest of using private attributes along getters there @Freezman31?

@florian-lefebvre florian-lefebvre added the question Further information is requested label Oct 7, 2021
@florian-lefebvre florian-lefebvre added this to TODO in Roadmap Oct 7, 2021
@Freezman31
Copy link
Member

It's my Java habits x)
I'm going to change this

@Freezman31
Copy link
Member

Done

Roadmap automation moved this from To do to Done Oct 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
Development

No branches or pull requests

2 participants