Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Readability and documentation of Builders.kt #100

Closed
ronsmits opened this issue Apr 29, 2016 · 3 comments
Closed

Readability and documentation of Builders.kt #100

ronsmits opened this issue Apr 29, 2016 · 3 comments

Comments

@ronsmits
Copy link
Contributor

I was reading the builders.kt to understand how some of the builders work.

The readability of this file is going down a bit and makes it (IMHO) harder to read for us noobs. Do you mind if I spend some time on it this weekend. Clean it up a bit?

@edvin
Copy link
Owner

edvin commented Apr 29, 2016

Thanks for pointing that out, Ron :) I'm about to start #57 this weekend, so Builders.kt will probably be gone come Monday. Hang on until I'm done restructuring, and then you can play with it, OK? I will let you know on this issue.

@ronsmits
Copy link
Contributor Author

I will wait till you are ready :)

@edvin
Copy link
Owner

edvin commented May 3, 2016

I have done the initial refactoring. There might still be some functions that should be moved, and we'd need some headings and sort the functions better within each file. You're welcome to give it a shot now :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants