Some Selection Extension Properties should be nullable

[thomasnield]

Documenting another item that I will fix this weekend. Some of the selection extension properties should be nullable. For example, Nodes.kt has some controls with a selectedItem or selectedValue property that could be null.

val <T> TableView<T>.selectedItem: T
    get() = this.selectionModel.selectedItem

val <T> TreeView<T>.selectedValue: T
    get() = this.selectionModel.selectedItem.value

...

val <T> ListView<T>.selectedItem: T
    get() = selectionModel.selectedItem

val <T> ComboBox<T>.selectedItem: T
    get() = selectionModel.selectedItem

To avoid nullability issues, they should be this. I'll do a sweep later to ensure nullable extension properties are indeed nullable.

val <T> TableView<T?>.selectedItem: T?
    get() = this.selectionModel.selectedItem

val <T> TreeView<T?>.selectedValue: T?
    get() = this.selectionModel.selectedItem.value

...

val <T> ListView<T?>.selectedItem: T?
    get() = selectionModel.selectedItem

val <T> ComboBox<T/>.selectedItem: T?
    get() = selectionModel.selectedItem

[edvin]

Ah, thanks a lot! I knew about this, but actually used a workaround in my apps instead of fixing it for some strange reason :)

[thomasnield]

Haha I do that too. I tend to cope with small uninteresting problems and procrastinate on fixing them...

[edvin]

Yeah, good thing we don't procrastinate on the same things :) haha

Did you add this change or should I do it?

[thomasnield]

Ah forgot about this one. I'll do it today.

[thomasnield]

Doing this right now. What is the status of the release?

[thomasnield]

Okay done. I'll go ahead and merge.

[edvin]

Nice! I'll get in some changes to the logging support and documentat that, other than that I think I'm done. What about you?

[edvin]

Oh, and thanks for all the hard work lately, you've put in a lot of time and effort. Really appreciate it!

[edvin]

By the way, I reverted the T? type in the onUserSelect functions, as we do null check before calling :) The onUserSelect action will never be called unless there is a value for the selectedItem.

[thomasnield]

Got it. That makes sense.

[thomasnield]

No problem! Glad to help and I think that's it. I may go through documentation later and add more stuff. I already added example for menus to builders section.

[edvin]

Perfect! I'll release tonight :)