fix: drop version check as it seems to be not needed #19
Conversation
The current version check doesn't work with two digit minor/major release numbers breaking at 1.10.x As I didn't see a good reason to have this check in first place I dropped it. - closes edvisor-io#17
|
|
Probably a good idea as many of the project dependencies will no longer transpile for Node <8 (also it's only an informational flag so nothing will stop working for existing users). Meteor 1.8 users can still use v12+ to run the CLI globally as the Node/NPM versions are parsed from the Meteor CLI: https://github.com/EducationLink/meteor-google-cloud/blob/cb72dca6ab970ddf841f7c223ac665c6ad44fbf6/src/lib/google.js#L51-L58 |
|
@ramijarrar anything else i should do to push this forward? |
|
@sakulstra I'm not actually a maintainer of this repo 馃槃 (it was inspired by my Meteor Azure integration so I chimed in when I noticed the issue carried over) |
The current version check doesn't work with two digit minor/major release numbers breaking at 1.10.x
As I didn't see a good reason to have this check in first place I dropped it
I also noticed that package.json enforces:
could/should we update this to >=8/10?
10 because that's the oldest still supported node version
8 because a lot of people are still on meteor 1.8 馃槄