-
Notifications
You must be signed in to change notification settings - Fork 461
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Azure SQL is not supported #95
Comments
Yes that's fine - providing it also keeps working on SQL Server (which I assume is the case). |
Fixed in commit 9383def |
Can you check whether this is sufficient to fix the issue? |
This is the same change we made to our fork 👍 The only difference is that we did a |
Yes, it makes sense to explicitly open the connection. I'll create a fix for that. |
See commit f243358 I've also changed the SqlServerWorkshopPlanningEventSourceRepository of the WorkshopManagementAPI so its structure is identical to that of the other two repos. |
See: https://github.com/EdwinVW/pitstop/blob/master/src/NotificationService/Repositories/SqlServerNotificationRepository.cs#L39
DB_ID always returns NULL for azure sql (single database).
We could instead use
"IF NOT EXISTS(SELECT * FROM master.sys.databases WHERE name='Notification') CREATE DATABASE Notification;"
The USE command is also not allowed on azure sql single database which is used by ChangeDatabase: https://github.com/EdwinVW/pitstop/blob/master/src/NotificationService/Repositories/SqlServerNotificationRepository.cs#L44
We can replace this with closing the sql connection to master and creating a new sql connection to the target database.
This does work on azure sql. Would this change be acceptable?
The text was updated successfully, but these errors were encountered: