Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Workout Counter Sensor #46

Open
edwork opened this issue Jul 17, 2022 · 5 comments
Open

Add Workout Counter Sensor #46

edwork opened this issue Jul 17, 2022 · 5 comments
Assignees
Labels
enhancement New feature or request

Comments

@edwork
Copy link
Owner

edwork commented Jul 17, 2022

Add a sensor, set of sensors, or sensor with sub-attributes that counts how many workouts a user has taken. This could be useful to watch for upcoming milestones.

@edwork edwork added the enhancement New feature or request label Jul 17, 2022
@edwork edwork self-assigned this Jul 17, 2022
@edwork
Copy link
Owner Author

edwork commented Jan 16, 2023

@Miablo can you take a look at this one?

@Miablo
Copy link
Contributor

Miablo commented Jan 16, 2023

@edwork i think there is a bool value that can be read for is_milestone that can be used instead of a counter but let me look into it a bit more and see what I come up with

@edwork edwork assigned Miablo and unassigned edwork Jan 17, 2023
@RobertD502
Copy link
Contributor

RobertD502 commented Jan 28, 2023

Just to add to the discussion: The total number of workouts can be grabbed from the total_workouts key from the response returned by the GetMe function, which I see this integration is already calling.

Edit:
There is also a breakdown based on the type of work out and the total count for each of those. It may make sense to create sensors for these, but set them as disabled by default and allow users to enable whichever one's they'd like to enable/track.

@Miablo
Copy link
Contributor

Miablo commented Jan 28, 2023

yeah that would then require a manual milestone counter for each milestone we would want to alert the user about since my interpretation of the issue wasnt to just count workouts but to be able to trigger a "this is a milestone" for whatever fitness type

@RobertD502
Copy link
Contributor

I may be recalling incorrectly, but doesn't that alert already show up for users within the peloton app (mobile, bike, tread) when in a session that is a milestone ride, run, etc.?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants