This repository has been archived by the owner on Feb 27, 2024. It is now read-only.
YONK-348: Rename api_manager app and extract it to separate repo #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| def setUp(self): | ||
| super(RenameApiManagerAppTests, self).setUp() | ||
|
|
||
| self.old_appname = 'api_manager' |
There was a problem hiding this comment.
I think we should have value of old_appname something like dummy_old_app so it would not mix/conflict with installed_apps.
|
@msaqib52 over all LGTM just one modification in test. |
msaqib52
force-pushed
the
msaqib52/YONK-348
branch
from
ada6874
to
2b4093e
Compare
2 tasks
viadanna
added a commit
to open-craft/api-integration
that referenced
this pull request
Nov 29, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a part of consolidation work we are renaming
api_managerapp toedx_solutions_api_integrationand moving it to separate repo. This PR renamesapi_managerapp and updates all its references accordingly, fixes quality issues appeared during rename and adds a commandrename_api_manager_appto rename tables and updateapp_name(insouth_migrationhistorytable) andapp_label(indjango_content_typetable) related toapi_managerapp.@ziafazal would you please take a look?