-
Notifications
You must be signed in to change notification settings - Fork 21
Conversation
👍 |
source = oauth2_provider | ||
omit = | ||
**/__init__.py | ||
**/tests/* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I realize this is a loaded topic, but we had discussed including tests as part of coverage when talking about analytics best practices a month or two ago. It can help us stay on top of which tests we're actually using or which ones we're ignoring, etc. I'm pretty sure we track it on edx-platform, too, but could be wrong, here.
Unless you guys would like to discuss, I'd like to remove the two test lines from this file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was just making assumptions here about which files should be included in the coverage reports. I'll remove the tests from the omitted group.
The tests files is still open but the changes LGTM otherwise. |
Oh, and now's your chance to get the ticket# into a commit message if you'd like. |
TE-478
TE-478
c97da14
to
7ceb5d6
Compare
👍 |
@benpatterson Please review