Skip to content
This repository has been archived by the owner on Mar 3, 2020. It is now read-only.

Clytwynec/travis #11

Merged
merged 3 commits into from
Sep 24, 2014
Merged

Clytwynec/travis #11

merged 3 commits into from
Sep 24, 2014

Conversation

clytwynec
Copy link
Contributor

@benpatterson Please review

@clintonb
Copy link
Contributor

👍

source = oauth2_provider
omit =
**/__init__.py
**/tests/*

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I realize this is a loaded topic, but we had discussed including tests as part of coverage when talking about analytics best practices a month or two ago. It can help us stay on top of which tests we're actually using or which ones we're ignoring, etc. I'm pretty sure we track it on edx-platform, too, but could be wrong, here.

Unless you guys would like to discuss, I'd like to remove the two test lines from this file.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was just making assumptions here about which files should be included in the coverage reports. I'll remove the tests from the omitted group.

@benpatterson
Copy link

The tests files is still open but the changes LGTM otherwise.

@benpatterson
Copy link

Oh, and now's your chance to get the ticket# into a commit message if you'd like.

@benpatterson
Copy link

👍

clytwynec pushed a commit that referenced this pull request Sep 24, 2014
@clytwynec clytwynec merged commit 7989a26 into edx:master Sep 24, 2014
@clytwynec clytwynec deleted the clytwynec/travis branch September 24, 2014 19:22
jenkins-ks pushed a commit to nttks/edx-oauth2-provider that referenced this pull request Sep 16, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants