[INCR-22] Support testing Python 3 in edx-oauth2-provider #58
Conversation
|
Thanks for the pull request, @jonkiparsky! I've created OSPR-3450 to keep track of it in JIRA. JIRA is a place for product owners to prioritize feature reviews by the engineering development teams. Feel free to add as much of the following information to the ticket:
All technical communication about the code itself will still be done via the GitHub pull request interface. As a reminder, our process documentation is here. |
|
@jonkiparsky Thank you for your contribution. Please let me know once all tests are green. |
|
@jmbowman Sorry about the delay on this, but I think this is ready for you now (getting all and only the expected failures) |
tox.ini
Outdated
| @@ -1,5 +1,5 @@ | |||
| [tox] | |||
| envlist = django{18,110,111} | |||
| envlist = py{36,37}-django{111,20,21,22} | |||
There was a problem hiding this comment.
Should probably add py27 to this also.
tox.ini
Outdated
| django111: Django>=1.11,<2.0 | ||
| django20: Django>=2.0,<2.1 | ||
| django21: Django>=2.1,<2.2 | ||
| django22: Django>=2.2 |
There was a problem hiding this comment.
This should have an upper bound in preparation for when the next major version of Django is released.
| - TOXENV=django111 | ||
| - TOXENV=django20 | ||
| - TOXENV=django21 | ||
| - TOXENV=django22 |
There was a problem hiding this comment.
The failing test workers should be flagged as ok to fail via allow_failures until they can be fixed: https://docs.travis-ci.com/user/customizing-the-build/#rows-that-are-allowed-to-fail
|
@jmbowman Thanks for the feedback. Hope this is satisfactory. |
|
@jmbowman This is ready for your review. |
There was a problem hiding this comment.
Thanks for getting that sorted out! We're looking into a switch from Travis to GitLab CI, which actually allows local execution of configured tests. Oh, and obligatory XKCD: https://xkcd.com/1296/
|
@jonkiparsky 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
JIRA link
Changes:
testin Makefile, which was attempting to run coverage as well as testsmake testandmake coverageto runNote:
make test-allruns with failures, as expected.