Skip to content
This repository has been archived by the owner on May 14, 2024. It is now read-only.

Support multiple Open edX devstacks #88

Conversation

arbrandes
Copy link

@arbrandes arbrandes commented Sep 30, 2020

Description

This allows for multiple edX devstacks (introduced via https://github.com/edx/devstack/pull/532) by letting the user specify which compose project to target.

It also adds a couple of convenience Makefile targets.

Test Instructions

For the simplest test, pulling in this PR should not affect the maintenance of an existing devstack, or creating a new one as usual.

To actually test the feature introduced here, one must first create a new Open edX devstack using a separate compose project. See the instructions in the README. Then, export OPENEDX_PROJECT_NAME accordingly and check if blockstore provisions and runs correctly.

@openedx-webhooks openedx-webhooks added needs triage open-source-contribution PR author is not from Axim or 2U labels Sep 30, 2020
@openedx-webhooks
Copy link

Thanks for the pull request, @arbrandes! I've created OSPR-5021 to keep track of it in JIRA, where we prioritize reviews. Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@arbrandes
Copy link
Author

@bradenmacdonald, as a user of multiple simultaneous devstacks (and blockstores), I've been maintaining this for my own use for a while, but after the latest rebase onto the Python 3.5/3.8 stuff, I'd much rather get this upstream and save me the trouble. (I know blockstore is moving into edx-platform some time soon, but this should still be useful in the meantime.) Mind taking a quick look as Core Commiter?

@bradenmacdonald
Copy link
Contributor

@arbrandes Yes I can, but not until sometime next sprint. Can you get someone else to do a first review in the meantime? If I'm reviewing+merging as Core Committer it should have another review first.

@arbrandes
Copy link
Author

@bradenmacdonald, sure thing, and thanks!

@natabene
Copy link

natabene commented Oct 1, 2020

@arbrandes Thank you for your contribution.
@bradenmacdonald I see you will be a core committer for this, thanks!

@bradenmacdonald
Copy link
Contributor

@arbrandes Welcome back. Can you please rebase this? I'll review it next week.

@bradenmacdonald
Copy link
Contributor

@arbrandes ^ ping :) When you have some time.

@arbrandes arbrandes force-pushed the arbrandes/multiple-edx-devstacks branch 2 times, most recently from 00ca1db to 4bcfaec Compare November 27, 2020 14:48
This allows for multiple edX devstacks (introduced via
https://github.com/edx/devstack/pull/532) by letting the user specify
which compose project to target.

It also adds a couple of convenience Makefile targets.
@arbrandes arbrandes force-pushed the arbrandes/multiple-edx-devstacks branch from 4bcfaec to 2efd8cc Compare November 27, 2020 14:49
Copy link
Contributor

@bradenmacdonald bradenmacdonald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Do you want me to merge now ?

  • I tested this: ran make easyserver, tested, ran make testserver, ran tests. Did not test with multiple devstacks, just regular
  • I read through the code
  • I checked for accessibility issues: n/a
  • Includes documentation: yep

@arbrandes
Copy link
Author

@bradenmacdonald, this is good to merge, yes, thanks!

@bradenmacdonald bradenmacdonald merged commit 40e32a7 into openedx-unsupported:master Dec 1, 2020
@openedx-webhooks
Copy link

@arbrandes 🎉 Your pull request was merged!

Please take a moment to answer a two question survey so we can improve your experience in the future.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants