Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BD-6] Add tests in python 3.8 #11

Merged
merged 1 commit into from
May 7, 2020
Merged

Conversation

morenol
Copy link

@morenol morenol commented May 6, 2020

Description

Add tests with python 3.8
Drop support for python 2.7
Run make upgrade
Move quality test to its own travis worker.
Create new release

Reviewers

@openedx-webhooks
Copy link

Thanks for the pull request, @morenol! I've created OSPR-4479 to keep track of it in JIRA. JIRA is a place for product owners to prioritize feature reviews by the engineering development teams.

Feel free to add as much of the following information to the ticket:

  • supporting documentation
  • edx-code email threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will still be done via the GitHub pull request interface. As a reminder, our process documentation is here.

@coveralls
Copy link

coveralls commented May 6, 2020

Coverage Status

Coverage increased (+0.2%) to 97.807% when pulling 716fbef on eduNEXT:lmm/py38 into 104ca7b on edx:master.

@morenol morenol force-pushed the lmm/py38 branch 3 times, most recently from 6dfc118 to 6d7079d Compare May 6, 2020 20:37
@morenol morenol marked this pull request as ready for review May 6, 2020 20:44
Upgrade packages

New release
@morenol
Copy link
Author

morenol commented May 7, 2020

@awais786 I think that this is ready to merge

@awais786 awais786 merged commit 99dade9 into openedx:master May 7, 2020
@openedx-webhooks
Copy link

@morenol 🎉 Your pull request was merged!

Please take a moment to answer a two question survey so we can improve your experience in the future.

@openedx-webhooks openedx-webhooks added blended PR is managed through 2U's blended developmnt program merged and removed needs triage open-source-contribution PR author is not from Axim or 2U labels Jan 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blended PR is managed through 2U's blended developmnt program merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants