Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating python and django in Travis and Tox #37

Merged
merged 1 commit into from
May 6, 2020
Merged

Updating python and django in Travis and Tox #37

merged 1 commit into from
May 6, 2020

Conversation

UsamaSadiq
Copy link
Member

@UsamaSadiq UsamaSadiq commented Apr 24, 2020 •
edited
Loading

Issue: BOM-1565

Description

  • Removed support for py27, py36, django111, django20 and django21.
  • Added support for python3.8.
  • Updated constraints & setup file.
  • Updated version to 0.3.4.

@UsamaSadiq UsamaSadiq marked this pull request as ready for review April 24, 2020 10:40
mzulqarnain1
mzulqarnain1 approved these changes Apr 24, 2020
View reviewed changes
.travis.yml Outdated Show resolved Hide resolved
@UsamaSadiq UsamaSadiq force-pushed the usamasadiq/bom-1565 branch 2 times, most recently from b789541 to 127d0d6 Compare April 29, 2020 12:44
@mzulqarnain1 mzulqarnain1 mentioned this pull request Apr 29, 2020
Merged
@UsamaSadiq UsamaSadiq force-pushed the usamasadiq/bom-1565 branch 2 times, most recently from 9bbecc4 to c5c0a53 Compare April 30, 2020 11:03
@morenol
Copy link

morenol commented Apr 30, 2020

Please add an entry with the changes in the changelog

@UsamaSadiq UsamaSadiq requested a review from jmbowman May 4, 2020 12:51
jmbowman
jmbowman reviewed May 4, 2020
View reviewed changes
Copy link

@jmbowman jmbowman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me also except the missing changelog entry (seems like the previous release forgot to update it also).

@UsamaSadiq UsamaSadiq requested a review from jmbowman May 5, 2020 15:40
@UsamaSadiq UsamaSadiq merged commit 6b38271 into master May 6, 2020
@UsamaSadiq UsamaSadiq deleted the usamasadiq/bom-1565 branch May 6, 2020 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@awais786 awais786 awais786 approved these changes

@jmbowman jmbowman jmbowman approved these changes

@mzulqarnain1 mzulqarnain1 mzulqarnain1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@UsamaSadiq @morenol @awais786 @jmbowman @mzulqarnain1