temp: Postpone Datadog APM profiling #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robrap
approved these changes
Jun 4, 2024
|
@rijuma: Consider changing |
rijuma
changed the title
rijuma
force-pushed
the
rijuma/postpone-datadog-apm-profiling
branch
from
794f0ba
to
95c6f6d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on 馃敀this slack thread, there's a potential risk on having both Datadog and NewRelic profiling enabled.
Insights was not deployed yet with these options enabled. It would be safer to roll back the changes made in this previous PR #26 before deploying to prod and enable the feature.