Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added install:configuration tag to step that sets up forum env #4049

Merged
merged 8 commits into from Oct 3, 2017
Merged

Added install:configuration tag to step that sets up forum env #4049

merged 8 commits into from Oct 3, 2017

Conversation

blarghmatey
Copy link
Contributor

When updating configuration settings on the Forum service, changed passwords for MongoDB were not being set if the Ansible playbook is targeting the install:configuration tag. Adding that tag to the setup the forum env step addresses this issue.

Make sure that the following steps are done before merging:

  • A DevOps team member has approved the PR.
  • Are you adding any new default values that need to be overridden when this change goes live? If so:
    • Update the appropriate internal repo (be sure to update for all our environments)
    • If you are updating a secure value rather than an internal one, file a DEVOPS ticket with details.
    • Add an entry to the CHANGELOG.
  • Have you performed the proper testing specified on the Ops Ansible Testing Checklist?

@openedx-webhooks
Copy link

Thanks for the pull request, @blarghmatey! I've created OSPR-1876 to keep track of it in JIRA. JIRA is a place for product owners to prioritize feature reviews by the engineering development teams.

Feel free to add as much of the following information to the ticket:

  • supporting documentation
  • edx-code email threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will still be done via the GitHub pull request interface. As a reminder, our process documentation is here.

If you like, you can add yourself to the AUTHORS file for this repo, though that isn't required. Please see the CONTRIBUTING file for more information.

@openedx-webhooks openedx-webhooks added needs triage open-source-contribution PR author is not from Axim or 2U labels Aug 17, 2017
@feanil
Copy link
Contributor

feanil commented Aug 17, 2017

Seems good to me, is there an equivalent PR in master?

@blarghmatey
Copy link
Contributor Author

Not yet, I'll add that in.

@blarghmatey
Added the option to split env_extras by app
24ad6e2 
Added `EDXAPP_LMS_ENV_EXTRAS` and `EDXAPP_CMS_ENV_EXTRAS` to default vars in order to be able to have different values for the `env_extras` between LMS and CMS.
@blarghmatey
Updated forum tags to update env settings on configuration
7111a47 
Added the `install:configuration` tag to the step that writes the forum_env to disk so that updated mongodb credentials
are properly propagated to the service during deployments.
@shaidar @blarghmatey
Added a way to override having the aws role be installed. In cases wh…
202bdbd 
…ere a local host is being used, aws role is not needed. Default remains true though.
@gsong
Copy link
Contributor

gsong commented Aug 23, 2017

@blarghmatey Why don't we change the target of this PR to be master? Once it's merged then we can cherry pick and back port to open-release/ginkgo.master and open-release/ficus.master?

Thanks.

@openedx-webhooks openedx-webhooks added community manager review waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. and removed needs triage community manager review labels Aug 23, 2017
blarghmatey and others added 5 commits September 25, 2017 11:42
@blarghmatey
Exposed configuration of atomic requests
a4c9d16 
Added the option of overriding atomic requests without having to override the entire database configuration structure.
@ziafazal @blarghmatey
ignore node_modules directory while compiling python files
2fa76a2 
signle quoted regex
@mtyaka @blarghmatey
Find name of default network interface to set MTU.
932b351 
On Ubuntu 16.04, the default networks interface is not always called
eth0, depending on the hardware. The name of the default network
interface on some VM types on AWS is ens3, for example.

Determine the interface name using ip route command instead of
hardcoding to eth0.

Also, /etc/network/interfaces.d/<interface-name>.cfg files no longer
exist in Ubuntu 16.04. Use a script in /etc/network/if-up.d to
adjust the MTU value at startup instead.
@mtyaka @blarghmatey
Interface name is not always last token in output.
1222f5a
@mtyaka @blarghmatey
Use built-in ansible_default_ipv4 variable.
3d9f00f 
It turns out ansible already provides info about the default network
interface in the ansible_default_ipv4 dict variable, so we can use that
instead of using the 'ip route show' command.
This was referenced Oct 3, 2017
Merged
Merged
@gsong gsong merged commit 3161476 into openedx:open-release/ficus.master Oct 3, 2017
@openedx-webhooks
Copy link

@blarghmatey 🎉 Your pull request was merged!

Please take a moment to answer a two question survey so we can improve your experience in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
open-source-contribution PR author is not from Axim or 2U waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@blarghmatey @openedx-webhooks @feanil @gsong @shaidar @ziafazal @mtyaka