Optional aws role and EDXAPP_MYSQL_ATOMIC_REQUESTS
#4126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added the `install:configuration` tag to the step that writes the forum_env to disk so that updated mongodb credentials are properly propagated to the service during deployments.
…ere a local host is being used, aws role is not needed. Default remains true though.
Added the option of overriding atomic requests without having to override the entire database configuration structure.
signle quoted regex
feanil
approved these changes
Oct 3, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a port of #4049 to
ginkgo.master. Most of the changes have been incorporated, here are the remaining stuff from that PR./cc @blarghmatey @feanil @nedbat