Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARCH-233: Add JWT Auth Middleware. #586

Merged
merged 1 commit into from Oct 4, 2018

Conversation

robrap
Copy link
Contributor

@robrap robrap commented Oct 3, 2018

From edx-drf-extensions:

  1. EnsureJWTAuthSettingsMiddleware: Ensures proper JWT auth settings
    for endpoints.
  2. JwtAuthCookieMiddleware: Combines the JWT auth cookie parts into a
    JWT auth cookie.

ARCH-233

Credentials Pull Request

Make sure that the following steps are done before rebasing/merging

  • Request a review if desired
  • Squash/Fixup your branch to one commit
  • Config/Dependency Changes (e.g. config files, scripts that are used for provisioning etc.)
  • UI Changes
    • Consider other browsers (e.g. Firefox)
    • Check mobile view
    • Consider accessibility (e.g. Run aXe on the page)

From edx-drf-extensions:
1. EnsureJWTAuthSettingsMiddleware: Ensures proper JWT auth settings
   for endpoints.
2. JwtAuthCookieMiddleware: Combines the JWT auth cookie parts into a
   JWT auth cookie.

ARCH-233
@robrap robrap requested a review from nasthagiri October 3, 2018 20:48
@robrap robrap merged commit 7726f1b into master Oct 4, 2018
@robrap robrap deleted the robrap/ARCH-233-jwt-auth-middleware branch October 4, 2018 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant