Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BOM-2027 : Fix Python 3.5 test failures #96

Merged
merged 1 commit into from Oct 8, 2020
Merged

BOM-2027 : Fix Python 3.5 test failures #96

merged 1 commit into from Oct 8, 2020

Conversation

mzulqarnain1
Copy link

@mzulqarnain1 mzulqarnain1 commented Sep 25, 2020 •
edited

@mzulqarnain1 mzulqarnain1 marked this pull request as ready for review September 28, 2020 08:34
@mzulqarnain1
Copy link
Author

@morenol Please review.

morenol
morenol approved these changes Sep 29, 2020
View reviewed changes
Copy link
Contributor

@morenol morenol left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,

Could you add to the deploy section of travis a parameter that only upload this to PyPI if TARGETS="quality"?

@morenol morenol mentioned this pull request Sep 29, 2020
Closed
@mzulqarnain1
Copy link
Author

LGTM,

Could you add to the deploy section of travis a parameter that only upload this to PyPI if TARGETS="quality"?

@morenol Done.

@mzulqarnain1 mzulqarnain1 force-pushed the bom-2027 branch 2 times, most recently from 711455b to 5826bdb Compare October 1, 2020 09:15
awais786
awais786 reviewed Oct 7, 2020
View reviewed changes
requirements/base.txt Outdated Show resolved Hide resolved
@mzulqarnain1 mzulqarnain1 merged commit cacb996 into master Oct 8, 2020
@mzulqarnain1 mzulqarnain1 deleted the bom-2027 branch October 8, 2020 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@awais786 awais786 awais786 approved these changes

@morenol morenol morenol approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mzulqarnain1 @awais786 @morenol