Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tehreem/fix config from yaml error #2582

Closed

Conversation

tehreem-sadat
Copy link

No description provided.

brittneyexline and others added 30 commits July 25, 2018 12:24
…m to catalog"

This reverts commit 58174a6.

(cherry picked from commit 681cbb4)
add bluefin payment code

Fix double form validations

remove debugger

remove javascript alert messages

add requested changes: Use get for dict and remove string litterals

remove pep8 issues

remove pdb; remove configurations from oscar

remove post url from oscar

remove dummy values
move coonfiguration from ecommerce_env file to yaml file
…on_issue

show warning error on button click
…code

Add e2e and issue credit (refund) code
change e2e => add strip line to run on dev server
tehreem-sadat and others added 22 commits August 23, 2019 15:44
…uring_tests

Add some changes found during uni tests
…sor_tests

Add unit tests for AuthorizeNet payment processor
FIX: replace settings.get(KEY) with settings.KEY
…_dev_server

change email backend for devserver
@openedx-webhooks
Copy link

Thanks for the pull request, @tehreem-sadat! I've created OSPR-3842 to keep track of it in JIRA. JIRA is a place for product owners to prioritize feature reviews by the engineering development teams.

Feel free to add as much of the following information to the ticket:

  • supporting documentation
  • edx-code email threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will still be done via the GitHub pull request interface. As a reminder, our process documentation is here.

We can't start reviewing your pull request until you've submitted a signed contributor agreement or indicated your institutional affiliation. Please see the CONTRIBUTING file for more information.

@openedx-webhooks
Copy link

@tehreem-sadat Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future.

@danialmalik danialmalik deleted the tehreem/fix_config_from_yaml_error branch November 25, 2019 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U rejected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants