Skip to content
This repository has been archived by the owner on May 6, 2024. It is now read-only.

Add NSBluetoothAlwaysUsageDescription key to edX-Info.plist file #1307

Merged

Conversation

andrey-canon
Copy link
Contributor

Description

This fixes the following error, that is generated, when a new build is uploaded to itunes.

ITMS-90683: Missing Purpose String in Info.plist - Your app's code references one or more APIs that 
access sensitive user data. The app's Info.plist file should contain a 
NSBluetoothAlwaysUsageDescription key with a user-facing purpose string explaining clearly and 
completely why your app needs the data. Starting Spring 2019, all apps submitted to the App Store 
that access user data are required to include a purpose string. If you're using external libraries or 
SDKs, they may reference APIs that require a purpose string. While your app might not use these
 APIs, a purpose string is still required. You can contact the developer of the library or SDK and 
request they release a version of their code that doesn't contain the APIs. Learn more 
(https://developer.apple.com/documentation/uikit/core_app/protecting_the_user_s_privacy). 

@openedx-webhooks
Copy link

Thanks for the pull request, @andrey-canon! I've created OSPR-3883 to keep track of it in JIRA. JIRA is a place for product owners to prioritize feature reviews by the engineering development teams.

Feel free to add as much of the following information to the ticket:

  • supporting documentation
  • edx-code email threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will still be done via the GitHub pull request interface. As a reminder, our process documentation is here.

@openedx-webhooks openedx-webhooks added needs triage open-source-contribution PR author is not from Axim or 2U labels Oct 11, 2019
@codecov
Copy link

codecov bot commented Oct 11, 2019

Codecov Report

Merging #1307 into master will increase coverage by <1%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #1307    +/-   ##
=======================================
+ Coverage      54%     54%   +<1%     
=======================================
  Files         422     422            
  Lines       26607   26607            
=======================================
+ Hits        14410   14416     +6     
+ Misses      12197   12191     -6
Impacted Files Coverage Δ
Source/CutomePlayer/VideoPlayer.swift 56% <0%> (ø) ⬆️
Source/CutomePlayer/VideoPlayerControls.swift 82% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c56d204...c202803. Read the comment docs.

@natabene
Copy link

@andrey-canon Thank you for your contribution. @edx/ios-devs This is ready for your review when you have a chance.

Copy link
Contributor

@salman2013 salman2013 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@salman2013
Copy link
Contributor

@saeedbashir Could you also take a look into it.

@saeedbashir saeedbashir merged commit 4c73a4a into openedx-unsupported:master Oct 25, 2019
@openedx-webhooks
Copy link

@andrey-canon 🎉 Your pull request was merged!

Please take a moment to answer a two question survey so we can improve your experience in the future.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
merged open-source-contribution PR author is not from Axim or 2U
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants