Don't change warnings global settings #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@clintonb @mattdrayer Do you know why this line is here? A library function like this shouldn't be changing the global warnings settings. |
nedbat
force-pushed
the
ned/dont-fiddle-warnings-settings
branch
from
3c2f5be
to
0033c43
Compare
|
It looks like I'm the one who added this line, but I can't recall any particular reason for doing so. I believe it came about when adding test coverage for a DeprecationWarning workflow. |
|
I guess I'm gonna do this... 👍 |
clintonb
approved these changes
Dec 21, 2016
|
I have to link to @nedbat's excellent blog post about how he diagnosed this problem. Amazing perseverance, Ned! http://nedbatchelder.com//blog/201612/finding_test_coupling.html |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This line was causing test failures elsewhere in the edx-platform test suite, when warnings were appearing that shouldn't.
@clintonb @mattdrayer Do you know why this line is here? A library function like this shouldn't be changing the global warnings settings.
/cc @gsong