Don't change warnings global settings #18

Merged
merged 1 commit into from Dec 22, 2016

Projects

None yet

4 participants

@nedbat
Member
nedbat commented Dec 21, 2016 edited

This line was causing test failures elsewhere in the edx-platform test suite, when warnings were appearing that shouldn't.
@clintonb @mattdrayer Do you know why this line is here? A library function like this shouldn't be changing the global warnings settings.
/cc @gsong

@nedbat
Member
nedbat commented Dec 21, 2016

@clintonb @mattdrayer Do you know why this line is here? A library function like this shouldn't be changing the global warnings settings.
/cc @gsong

@nedbat nedbat Don't change warnings global settings
0033c43
@mattdrayer
Member

It looks like I'm the one who added this line, but I can't recall any particular reason for doing so. I believe it came about when adding test coverage for a DeprecationWarning workflow.

@mattdrayer
Member

I guess I'm gonna do this... 👍

@clintonb

I have no clue why this exists.

@andy-armstrong
Member

I have to link to @nedbat's excellent blog post about how he diagnosed this problem. Amazing perseverance, Ned!

http://nedbatchelder.com//blog/201612/finding_test_coupling.html

@nedbat nedbat merged commit fe09c91 into master Dec 22, 2016

4 checks passed

codecov/patch 100% of diff hit (target 95.00%)
Details
codecov/project 100% (target 95.00%)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@nedbat nedbat deleted the ned/dont-fiddle-warnings-settings branch Dec 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment