Python Code Cleanup #135
Merged
Python Code Cleanup #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nedbat
reviewed
Jan 11, 2021
edx_lint/pylint/unicode_check.py
Outdated
| # Python 3 doesn't have this issue. | ||
| return | ||
| # Python 3 doesn't have this issue. | ||
| return |
There was a problem hiding this comment.
This entire file can be removed, right?
nedbat
reviewed
Jan 11, 2021
tox.ini
Outdated
| pylint --version | ||
| coverage run -p -m pytest {posargs:} | ||
| deps = | ||
| -r{toxinidir}/requirements/test.txt |
There was a problem hiding this comment.
This is putting tabs into the file. It shouldn't.
There was a problem hiding this comment.
I've made a pull request for repo-tools to fix this: openedx/repo-tools#157
mraarif
force-pushed
the
jenkins/cleanup-python-code-e9524eb
branch
2 times, most recently
from
0df9d9d
to
ac417e3
Compare
mzulqarnain1
approved these changes
Jan 21, 2021
mraarif
force-pushed
the
jenkins/cleanup-python-code-e9524eb
branch
from
ac417e3
to
145a0e1
Compare
nedbat
approved these changes
Jan 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python code cleanup by the cleanup-python-code Jenkins job.
This pull request was generated by the cleanup-python-code Jenkins job, which ran
The following packages were installed:
pyupgrade,git+https://github.com/edx/repo-tools.git@c05453b733602ba7a2224ffbbf58a8d0903b62d8