Fix pylint violations.

milestones/data.py

@@ -26,10 +26,12 @@
 """
 from __future__ import absolute_import
 from __future__ import unicode_literals
+
+import six
+
 from . import exceptions
 from . import models as internal
 from . import serializers
-import six
 
 
 # PRIVATE/INTERNAL METHODS (public methods located further down)
@@ -177,7 +179,7 @@ def fetch_milestone(milestone_id):
         exceptions.raise_exception("Milestone", {'id': milestone_id}, exceptions.InvalidMilestoneException)
     milestone = {'id': milestone_id}
     milestones = fetch_milestones(milestone)
-    if not len(milestones):
+    if not milestones:
         exceptions.raise_exception("Milestone", milestone, exceptions.InvalidMilestoneException)
     return milestones[0]
 

milestones/validators.py

@@ -3,13 +3,14 @@
 """
 from __future__ import absolute_import
 from __future__ import unicode_literals
+
 import json
+import six
 
 from opaque_keys import InvalidKeyError
 from opaque_keys.edx.keys import CourseKey, UsageKey
 
 from .data import fetch_milestone_relationship_types
-import six
 
 
 def course_key_is_valid(course_key):
@@ -63,9 +64,9 @@ def milestone_data_is_valid(milestone_data):
         return False
     if 'id' in milestone_data and not milestone_data.get('id'):
         return False
-    if 'name' in milestone_data and not len(milestone_data.get('name')):
+    if 'name' in milestone_data and not milestone_data.get('name'):
         return False
-    if 'namespace' in milestone_data and not len(milestone_data.get('namespace')):
+    if 'namespace' in milestone_data and not milestone_data.get('namespace'):
         return False
     return True
 

test_requirements.txt

@@ -1,13 +1,13 @@
-astroid==1.3.8  # Pinning to avoid backwards incompatibility issue with pylint/pylint-django
 coveralls
+astroid==1.5.3
+edx-lint
+tox
 coverage==4.5.3
 django_nose>=1.4.1
 nose==1.3.3
 httpretty==0.8.0
 pep8==1.5.7
-pylint==1.2.1
 pep257==0.3.2
 mock==1.0.1
 testfixtures==4.0.0
 ddt==0.8.0
-tox>=2.3.1,<3.0.0