ARCH-233: Add JWT Auth Middleware. #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robrap
force-pushed
the
robrap/ARCH-233-jwt-auth-middleware
branch
from
29f7b7e
to
1b97720
Compare
|
@nasthagiri: edx-notes-api has no JWT_AUTH setting, so I would need to set this up in configuration and presumably internals. |
|
@nasthagiri: I started on this work, but I think it would be better to try to deploy what we can tomorrow before the other PRs rot and need additional rebasing. |
robrap
force-pushed
the
robrap/ARCH-233-jwt-auth-middleware
branch
from
c79e358
to
546f110
Compare
|
FYI: Don't merge until the configuration change is in place: |
From edx-drf-extensions: 1. EnsureJWTAuthSettingsMiddleware: Ensures proper JWT auth settings for endpoints. 2. JwtAuthCookieMiddleware: Combines the JWT auth cookie parts into a JWT auth cookie. ARCH-233
robrap
force-pushed
the
robrap/ARCH-233-jwt-auth-middleware
branch
from
546f110
to
d4cbce2
Compare
Codecov Report
@@ Coverage Diff @@
## master #65 +/- ##
=======================================
Coverage 85.37% 85.37%
=======================================
Files 14 14
Lines 417 417
Branches 42 42
=======================================
Hits 356 356
Misses 51 51
Partials 10 10Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From edx-drf-extensions:
for endpoints.
JWT auth cookie.
ARCH-233
Pre-merge: