Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only build travis push on master #69

Merged
merged 1 commit into from Dec 7, 2018
Merged

Conversation

michaelyoungstrom
Copy link
Contributor

@michaelyoungstrom michaelyoungstrom commented Dec 6, 2018

I've been working on adding some automation for creating and testing openedx releases, which creates branches in a number of IDA's, and (if desired) deletes them at the end of the tests. For now, the job is in the beginning stages, and just creates a branch, and later deletes it.

The problem is, the branch gets deleted so quickly, that travis gets kicked off, but quickly fails when the branch can't be found. To make matters worse, since the branch doesn't include any new commits, travis gets run (and fails) on the same commit as the tip of the master branch, which overwrites whatever status it previously had to failing (example: link to failing travis build).

This change fixes that, by following a travis pattern we currently already use in other repos, like these: (configuration repo, devstack repo). This will limit builds to being triggered either by a pull request, or a push to master.

So when any non-master branch gets created or pushed, travis will not be triggered (unless there is an open pull request for that branch).

@codecov-io
Copy link

Codecov Report

Merging #69 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master     #69   +/-   ##
======================================
  Coverage    85.4%   85.4%           
======================================
  Files          14      14           
  Lines         418     418           
  Branches       42      42           
======================================
  Hits          357     357           
  Misses         51      51           
  Partials       10      10

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c0a52d...9456e33. Read the comment docs.

@michaelyoungstrom michaelyoungstrom merged commit ccc0125 into master Dec 7, 2018
@michaelyoungstrom michaelyoungstrom deleted the youngstrom/travis branch December 7, 2018 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants