Fix tests

.travis.yml

@@ -1,32 +1,18 @@
 language: python
-
-
 python:
   - "2.7"
-
 env:
-  - TRAVIS_MODE=1
-
-
-before_install:
-  - export DJANGO_SETTINGS_MODULE=settings
+  - DJANGO_SETTINGS_MODULE=settings
 
-
-# command to install dependencies
 install:
-    - "pip install coveralls"
-    - "pip install pep8"
-    - "pip install pylint==1.2.1"
     - "pip install -r requirements.txt"
     - "pip install -r test_requirements.txt"
+    - "pip install coveralls"
 
-
-# command to run tests and quality checks
 script:
     - coverage run ./manage.py test
     - coverage report -m
-    - pep8 --config=.pep8 notifications
-    - pylint --rcfile=.pylintrc notifications --report=no
-
+    - pep8 notifications
+    - pylint notifications --report=no
 
 after_success: coveralls

notifications/base_data.py

@@ -107,7 +107,7 @@ def __setattr__(self, attribute, value):
         We want our data models to have a schema that is fixed as design time!!!
         """
 
-        if not attribute in dir(self):
+        if attribute not in dir(self):
             raise ValueError(
                 (
                     "Attempting to add a new attribute '{name}' that was not part of "

notifications/store/tests/test_store.py

@@ -19,4 +19,4 @@ def test_cannot_create_instance(self):
         """
 
         with self.assertRaises(TypeError):
-            BaseNotificationStoreProvider()
+            BaseNotificationStoreProvider()  # pylint: disable=abstract-class-instantiated

notifications/tests/test_data.py

@@ -4,7 +4,7 @@
 
 from django.test import TestCase
 
-from notifications.data import (
+from notifications.data import (  # pylint: disable=unused-import
     NotificationMessage,
 )
 

requirements.txt

@@ -4,16 +4,5 @@ django-model-utils==1.4.0
 South>=0.7.6
 python-dateutil==2.1
 
-# Testing Packages
-coverage==3.7.1
-django_nose
-nose==1.3.3
-httpretty==0.8.0
-pep8==1.5.7
-pylint==1.2.1
-pep257==0.3.2
-mock==1.0.1
-testfixtures==4.0.0
-
 # edX Packages
 -e git+https://github.com/edx/opaque-keys.git@cba8e23f53ff3ce9d1f45871986c8974576185c0#egg=opaque-keys

run_tests

@@ -7,8 +7,8 @@ ECHO 'Running test suite'
 coverage run manage.py test --verbosity=3
 coverage report -m
 coverage html
-pep8 --config=.pep8 notifications
-pylint --rcfile=.pylintrc notifications --report=no
+pep8 notifications
+pylint notifications --report=no
 ECHO ''
 ECHO 'View the full coverage report at {CODE_PATH}/edx-notifications/htmlcov/index.html'
 ECHO ''

test_requirements.txt

@@ -0,0 +1,10 @@
+# Testing Packages
+coverage==3.7.1
+django_nose
+nose==1.3.3
+httpretty==0.8.0
+pep8==1.5.7
+pylint==1.2.1
+pep257==0.3.2
+mock==1.0.1
+testfixtures==4.0.0