Skip to content
This repository has been archived by the owner on May 12, 2022. It is now read-only.

Commit

Permalink
Revert "bugs fixes as highlighted by Kashif in edx-notifications"
Browse files Browse the repository at this point in the history
  • Loading branch information
chrisndodge committed Mar 31, 2015
1 parent 5a8bfee commit e07c06c
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 9 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -132,14 +132,8 @@ var CounterIconView = Backbone.View.extend({
notification_alert.play();
}
counterView.render();
if (counterView.notification_pane && counterView.notification_pane.selected_pane == "unread") {
var url = counterView.options.endpoints.user_notifications_unread_only;
counterView.notification_pane.collection.url = url;

// apply namespacing - if set
if (counterView.namespace) {
counterView.notification_pane.collection.url = counterView.notification_pane.append_url_param(url, 'namespace', counterView.namespace)
}
if (counterView.notification_pane) {
counterView.notification_pane.collection.url = counterView.options.endpoints.user_notifications_unread_only;
counterView.notification_pane.hydrate();
}
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -442,7 +442,7 @@ var NotificationPaneView = Backbone.View.extend({
self.render();

// fetch the latest notification count
self.counter_icon_view.refresh();
self.counter_icon_view.model.fetch();
}
}
);
Expand Down

0 comments on commit e07c06c

Please sign in to comment.