-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Submission lock tests #1716
Submission lock tests #1716
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. A cleanup suggestion in your views and a test suggestion
This better matches the UUID structure in submissions
Modeled off of @jansenk's in-progress tests, to be merged later
Remove unused indexes. Remove default submission_uuid
In a test using the XBlockHandlerTestCaseMixin, running self.request with response_format='response' returns the entire response object instead of just the body. This is useful for asserts on status code
f7d167c
to
9e8811a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do a django migration squash and I'd say this is g2g
Or, you probably don't have to do a migration squash. just delete your migrations and re-generate the one |
* test: add tests for submission locking * refactor: update submission lock for timezone support * feat: allow a user to reacquire a submission lock * feat: add submission validation to submission lock * feat: add xblock test mode for returning response In a test using the XBlockHandlerTestCaseMixin, running self.request with response_format='response' returns the entire response object instead of just the body. This is useful for asserts on status code Co-authored-by: jansenk <jkantor@edx.org>
TL;DR - Add tests for submission locking XBlock handlers
JIRA: AU-345
What changed?
Developer Checklist
Testing Instructions
Python test suites should pass.
Reviewer Checklist
Collectively, these should be completed by reviewers of this PR:
FYI: @edx/masters-devs-gta