Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new character to list of invalid characters. #327

Merged
merged 1 commit into from
Jan 11, 2017

Conversation

dianakhuang
Copy link
Contributor

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling f9973bb on diana/new-invalid-char into 80a46ac on master.

@andy-armstrong
Copy link
Contributor

@dianakhuang Does it make sense to write a unit test for this? Have you determined what the behavior is currently if an ! is found?

@dianakhuang
Copy link
Contributor Author

In the current behavior, the ! is left in the payload. When we add it to this list, it is replaced by a _.

There already is a test (that I linked to) that iterates through the list of invalid characters and verifies that the invalid character is not present in the output. I don't know what other testing would be useful.

Copy link
Contributor

@andy-armstrong andy-armstrong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thanks so much for tracking this down!

@dianakhuang dianakhuang merged commit e6d6b05 into master Jan 11, 2017
@dianakhuang dianakhuang deleted the diana/new-invalid-char branch January 11, 2017 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants