Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

INCR-110: Upgrade freezegun #93

Merged
merged 2 commits into from
Mar 29, 2019
Merged

Conversation

jcdyer
Copy link
Contributor

@jcdyer jcdyer commented Mar 28, 2019

Fix broken test by ensuring all datetimes are timezone aware.
@edx/incr-reviewers

Fix broken test by ensuring all datetimes are timezone aware.
@openedx-webhooks
Copy link

Thanks for the pull request, @jcdyer! I've created OSPR-3257 to keep track of it in JIRA. JIRA is a place for product owners to prioritize feature reviews by the engineering development teams.

Feel free to add as much of the following information to the ticket:

  • supporting documentation
  • edx-code email threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will still be done via the GitHub pull request interface. As a reminder, our process documentation is here.

@openedx-webhooks openedx-webhooks added needs triage open-source-contribution PR author is not from Axim or 2U labels Mar 28, 2019
Copy link

@jmbowman jmbowman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the help with the test cleanup!

@jmbowman jmbowman merged commit aa71f35 into master Mar 29, 2019
@openedx-webhooks
Copy link

@jcdyer 🎉 Your pull request was merged!

Please take a moment to answer a two question survey so we can improve your experience in the future.

@natabene
Copy link

@jcdyer Thank you for your contribution.

@nsprenkle nsprenkle deleted the cliff/incr-110-upgrade-freezegun branch November 12, 2021 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged open-source-contribution PR author is not from Axim or 2U
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants