fix: clean up unused dependencies and env variables #471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Setting 'null' to an empty string '' (which is falsy and the right thing here)
- Removing a number of packages from dependencies that simply were not in use. - Removing 'font-awesome' dependency which we didn't actually need in our stylesheet - we don't use it, though we were importing it and setting a variable from it. Not sure why it was ever there.
Codecov Report
@@ Coverage Diff @@
## master #471 +/- ##
=======================================
Coverage 60.30% 60.30%
=======================================
Files 44 44
Lines 776 776
Branches 132 132
=======================================
Hits 468 468
Misses 298 298
Partials 10 10 Continue to review full report at Codecov.
|
We get 'history' through frontend-platform.
binodpant
reviewed
Aug 30, 2021
| @@ -12,26 +12,13 @@ LOGOUT_URL='http://localhost:18000/logout' | |||
| MARKETING_SITE_BASE_URL='http://localhost:18000' | |||
| ORDER_HISTORY_URL='localhost:1996/orders' | |||
| REFRESH_ACCESS_TOKEN_ENDPOINT='http://localhost:18000/login_refresh' | |||
| SEGMENT_KEY=null | |||
There was a problem hiding this comment.
is this because 'null' is treated as actually a truthy value? we have had this issue in our other repoes too where we had to use '' vs anything else for False, and True respectively
There was a problem hiding this comment.
Yes. null gets cast to a string and becomes truthy. Same with false. An empty string is falsy, though, when it hits JS so makes a much better default.
binodpant
approved these changes
Aug 30, 2021
snglth
pushed a commit
to Abstract-Tech/community-theme-profile
that referenced
this pull request
Jul 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This repo had a number of old environment variables that were no longer in use. It also had a number of dependencies that weren't actually used in code anywhere.
The only one that was used was font-awesome, but it was only 'used' to the extent that it was imported into the stylesheet and then... not used. They're all gone.